Reflects input changes to CBR

longshuicy commented 10 months ago

You might also want to update the workshop session 3 and 4 notebook to accept this new input in the PR? If it's not too much to do

Vismayak commented 10 months ago

@longshuicy I already did update the workshop notebooks, thats the one where I pushed to main by mistake

longshuicy commented 10 months ago

@longshuicy I already did update the workshop notebooks, thats the one where I pushed to main by mistake

That workshop notebook repos are private. Ya-Lan and Chris copied over the material to incore-docs so we can share it as a part of the documentation. Hence you might want to update it here.

They should be under the path of /manual_jb/content/workshops/20231115.

You need to modify session 3 & session 4. Session 4 you can just add

commercial_recovery.set_input_dataset("building_dmg", bldg_dmg_result)

Session 3 I haven't tried.
Lastly, when notebooks updated, you would need to creating a zip file of them, and place it under /workshops/20231115 to replace the outdated one. This is the place where we allow user to download the zipfile.

ylyangtw commented 9 months ago

Tested session3 in zip file, it works. session 4 changes also look good.

Could you remove the MACOSX in the zip file? If you simply use macos default to zip it, MACOSX will be generated automatically. You will want to use command line in the terminal instead.

Vismayak commented 9 months ago

@ylyangtw thats weird, I cant see it

If you still see it, could you please remove and commit it?

IN-CORE / incore-docs

Reflects input changes to CBR #311