143 add semantic template link in semantic viewer

IN-CORE / incore-ui

IN-CORE Web Tools: a component of IN-CORE. It consists of data viewer, hazard viewer, and fragility viewer.

https://incore.ncsa.illinois.edu

Mozilla Public License 2.0

4 stars 0 forks source link

143 add semantic template link in semantic viewer #149

Closed Rashmil-1999 closed 11 months ago

Rashmil-1999 commented 11 months ago

In this PR:

I add back the Semantic Viewer
Add Template download button #143
Improve Semantics viewer API logic #144

The Template button might not work because for some reason that API endpoint isn't available on dev

navarroc commented 11 months ago

Is it possible for the Download template button to be at the bottom of the page below the table? If so, what do others think about that location?

Rashmil-1999 commented 11 months ago

Yep, it is possible to move it there. Let me know if you want to do that.

navarroc commented 11 months ago

Could we move the button to a new line?

What do you think about the Download Template button being below the table @longshuicy? Is that too far out of view for a user? We could just put it on a new line as you suggested.

ylyangtw commented 11 months ago

Could we move the button to a new line?

What do you think about the Download Template button being below the table @longshuicy? Is that too far out of view for a user? We could just put it on a new line as you suggested.

Maybe make it similar to the viewer? So we only need one new line

Rashmil-1999 commented 11 months ago

How about this?

Rashmil-1999 commented 11 months ago

Is it possible for the Download template button to be at the bottom of the page below the table? If so, what do others think about that location?

I think for datatypes like buildingInventory7 and others which have long tables, that cause scrolling, the user would have to scroll all the way down to reach the button.

Like this

ylyangtw commented 11 months ago

Maybe we don't have to address this in this PR... would it be good if we hide/disable the download button if there is No Semantic Schema available? UI and code changes look good

Rashmil-1999 commented 11 months ago

Maybe we don't have to address this in this PR... would it be good if we hide/disable the download button if there is No Semantic Schema available? UI and code changes look good

So the thing is, if we don't have a column name available, we show that message so any schema that we don't have doesn't appear in the search in the first place, if there is, and if that has empty columns, we just show no Schema available.

So I think, after cleaning up, we should have everything working correctly.