IN-CORE / incore-ui

IN-CORE Web Tools: a component of IN-CORE. It consists of data viewer, hazard viewer, and fragility viewer.
https://incore.ncsa.illinois.edu
Mozilla Public License 2.0
4 stars 0 forks source link

Make github action to make the correct docker container tag #155

Closed ywkim312 closed 10 months ago

ywkim312 commented 11 months ago

The final release docker container tag contains the word 'v' in its tag name and this should be removed.

Rashmil-1999 commented 11 months ago

@ywkim312 Has this got something to do with how I created the tag?

ywkim312 commented 11 months ago

@ywkim312 Has this got something to do with how I created the tag?

no it is about github action when it generates docker images tag with v as the first character. You're release tag is find. It should start using the word 'v' but docker container image, we decided not to use 'v'

ywkim312 commented 10 months ago

The yaml file for github action looks correct. When it gets merged to main, it creates the correct versioned docker container. However, the release also creates the container that starts with "v" since the tag is will be "v***". Closing the issue