search

IN-CORE / pyincore-data

Mozilla Public License 2.0
0 stars 1 forks source link

Release/0.5.1 #40

Closed ywkim312 closed 2 years ago

ywkim312 commented 2 years ago

Updated library dependecies.

navarroc commented 2 years ago

Why is this pointing at develop and not main?

ywkim312 commented 2 years ago

Why is this pointing at develop and not main?

oops sorry about that. fixed

navarroc commented 2 years ago

Any idea why the pytest is taking so long to install it's dependencies? Seems stuck.

ywkim312 commented 2 years ago

I don't know why. In fact, it is doing the second and third one since I have pushed it three times. First one passed successfully and running the second and third now. But it takes very very long.

ywkim312 commented 2 years ago

Any idea why the pytest is taking so long to install it's dependencies? Seems stuck.

I checked the first one that finished successful, and it took 1h 42m only for setting up the dependencies. It is actually very similar thing that happens when incore-lab is built. Conda installation takes very very long for the github action or docker building unlike the local installation. I don't know why yet...

navarroc commented 2 years ago

Do we need a new RC build after these changes?

ywkim312 commented 2 years ago

Do we need a new RC build after these changes?

I am building one right now. However, it should be fine without those libraires. I tested in local and will test after rc one get built. If the built is successful, then it should work and it should be fine. I will test it anyway.

ywkim312 commented 2 years ago

Do we need a new RC build after these changes?

built and published pyincore-data 0.5.1.rc.3. Installation was successful. Tested with pyincore-data example notebook and ran successfully