fix NCI Functionality - Githubissues

IN-CORE / pyincore

pyIncore is a component of IN-CORE. It is a python package consisting of two primary components: 1) a set of service classes to interact with the IN-CORE web services, and 2) IN-CORE analyses . The pyIncore allows users to apply various hazards to infrastructure in selected areas, propagating the effect of physical infrastructure damage and loss of functionality to social and economic impacts.

Mozilla Public License 2.0

25 stars 7 forks source link

fix NCI Functionality #463

Closed longshuicy closed 11 months ago

longshuicy commented 11 months ago

Add EPF damage as an input; merge with EPF MCS so the DS_0, ..4 exist Also need to update the incore-doc markdowns to reflect this new input

This is where the error is; because MCS doesn't have DS_0-4 columns anymore: https://github.com/IN-CORE/pyincore/blob/develop/pyincore/analyses/ncifunctionality/ncifunctionality.py#L166
Adding a new input dataset in the specs epf_damage
Merging with the existing input dataset epf_subst_failure_results
And then merging with epn_nodes as what it previous did

Notes:

Make sure test in pyincore still works; you might have to update that test_ncixxxx.py script
Update the incore-docs markdown accordingly
Update the incore-docs jupyter notebook accordingly; I think it's already running a epfdamange, you just need to pipe the result in to nci