search

IN-CORE / pyincore

pyIncore is a component of IN-CORE. It is a python package consisting of two primary components: 1) a set of service classes to interact with the IN-CORE web services, and 2) IN-CORE analyses . The pyIncore allows users to apply various hazards to infrastructure in selected areas, propagating the effect of physical infrastructure damage and loss of functionality to social and economic impacts.
Mozilla Public License 2.0
25 stars 7 forks source link

508 implement slc ml cge #527

Closed Rashmil-1999 closed 6 months ago

Rashmil-1999 commented 6 months ago

This PR adds ML SLC CGE. I still have to remove 4 files based on what I get in the email reply.

You can test it by installing the current branch and running: python tests/pyincore/analyses/mlenabledcgeslc/test_mlcgeslc.py

navarroc commented 6 months ago

We need to update the modules.rst in the docs folder so it picks up the module documentation (docs/source/)

Rashmil-1999 commented 6 months ago

@navarroc This modifies the base CGE a little. Do you want me to point this PR to the core?

navarroc commented 6 months ago

@navarroc This modifies the base CGE a little. Do you want me to point this PR to the core?

I think we probably need to anyways because of the way the ML CGE PRs are all branched from the core CGE branch. Even without this change I think we would need to do that because otherwise when the core got merged/squashed, the individual CGE branches would contain the commits that got squashed and cause a problem. Also, since there is already a release branch for pyincore, I think the core branch needs to point to it instead of develop

navarroc commented 6 months ago

Final comment - can you put the spec definition at the bottom of the class?

navarroc commented 6 months ago

Almost final - there are some pep8 warnings, can you fix those?

Rashmil-1999 commented 6 months ago

Almost final - there are some pep8 warnings, can you fix those?

I don't see any warnings though. Could you tell me what those warnings are?