search

IN-CORE / pyincore

pyIncore is a component of IN-CORE. It is a python package consisting of two primary components: 1) a set of service classes to interact with the IN-CORE web services, and 2) IN-CORE analyses . The pyIncore allows users to apply various hazards to infrastructure in selected areas, propagating the effect of physical infrastructure damage and loss of functionality to social and economic impacts.
Mozilla Public License 2.0
25 stars 7 forks source link

531 add built in round support to the dfr3 evaluator #535

Closed longshuicy closed 6 months ago

longshuicy commented 6 months ago

To test, please run the pytest tests/pyincore/models/test_dfr3curve.py 

def test_fragility_eval()
...
navarroc commented 6 months ago

Looks good. There are a few pep8 errors about adding an extra line between functions. Can you fix those?

longshuicy commented 6 months ago

Looks good. There are a few pep8 errors about adding an extra line between functions. Can you fix those?

Which file do you see the pep8 error? for some reason my IDE doesn't prompt me with those anymore. :-(

navarroc commented 6 months ago

Looks good. There are a few pep8 errors about adding an extra line between functions. Can you fix those?

Which file do you see the pep8 error? for some reason my IDE doesn't prompt me with those anymore. :-(

Sorry, I should have been more clear. In the test_dfr3curve.py class. My IDE complains about needing an extra blank line for a few of the test methods.

longshuicy commented 6 months ago

Looks good. There are a few pep8 errors about adding an extra line between functions. Can you fix those?

Which file do you see the pep8 error? for some reason my IDE doesn't prompt me with those anymore. :-(

Sorry, I should have been more clear. In the test_dfr3curve.py class. My IDE complains about needing an extra blank line for a few of the test methods.

Ah i see them now. Thanks! Fixed :-)