search

IN-CORE / pyincore

pyIncore is a component of IN-CORE. It is a python package consisting of two primary components: 1) a set of service classes to interact with the IN-CORE web services, and 2) IN-CORE analyses . The pyIncore allows users to apply various hazards to infrastructure in selected areas, propagating the effect of physical infrastructure damage and loss of functionality to social and economic impacts.
Mozilla Public License 2.0
24 stars 7 forks source link

Fixed #519 removed unnecessary dependency #546

Closed navarroc closed 2 months ago

navarroc commented 3 months ago

openssl is not available through pip and breaks pip install of pyincore after 1.15.1. The openssl dependency is for conda installation.

navarroc commented 3 months ago

Whenever I install pyincore using pip in my local for test, I always remove this line. Why we need this for setup? Also without this, pyincore should be okay, right?

Yes, we don't need this. Actually, if you try to pip install pyincore you cannot install any version after 1.15.1 because of this dependency got added. environment.yml already handles adding this for the conda build/install of pyincore so it's not needed in setup.py

ywkim312 commented 3 months ago

Whenever I install pyincore using pip in my local for test, I always remove this line. Why we need this for setup? Also without this, pyincore should be okay, right?

Yes, we don't need this. Actually, if you try to pip install pyincore you cannot install any version after 1.15.1 because of this dependency got added. environment.yml already handles adding this for the conda build/install of pyincore so it's not needed in setup.py

Thanks. approve

navarroc commented 2 months ago

Does other openssl matters? I know environment.yaml is for conda, but what about e.g. requirements.min?

image

Let me try removing openssl altogether. We pinned the versions a while back because conda installing a higher version broken the github actions. Let me see what happens if I unpin the version in requirements.min.

navarroc commented 2 months ago

Looks like whatever the bug was with openssl got fixed so I have removed the version pin in requirements.min and environment.yml. This should be ready for final review. If you want, I can run the requirements.sh script to update the versions.md file.

navarroc commented 2 months ago

@longshuicy when you get a chance, can you take another look at this? Thanks!