568 - Create natural gas facility damage analysis

IN-CORE / pyincore

pyIncore is a component of IN-CORE. It is a python package consisting of two primary components: 1) a set of service classes to interact with the IN-CORE web services, and 2) IN-CORE analyses . The pyIncore allows users to apply various hazards to infrastructure in selected areas, propagating the effect of physical infrastructure damage and loss of functionality to social and economic impacts.

Mozilla Public License 2.0

24 stars 7 forks source link

568 - Create natural gas facility damage analysis #574

Closed navarroc closed 1 month ago

navarroc commented 1 month ago

[x] Created gas facility damage analysis
[x] Added module documentation
[x] Added test
[x] Compared results with Ergo analysis output

navarroc commented 1 month ago

Here is the ergo output for comparison with the test script: ergo-output

navarroc commented 1 month ago

Example notebook is in this PR for docs: https://github.com/IN-CORE/incore-docs/pull/388

navarroc commented 1 month ago

I think you might have to update the data type in that published gas facility inventory?

dataset type does not match - given type: ncsa:gasFacilityInventory spec types: ['ergo:gasFacilityInventory'] Error reading dataset: required dataset is missing - spec: {'id': 'gas_facilities', 'required': True, 'description': 'Gas facility Inventory', 'type': ['ergo:gasFacilityInventory']}

Is there an easy way to do that on dev?

longshuicy commented 1 month ago

I think you might have to update the data type in that published gas facility inventory? dataset type does not match - given type: ncsa:gasFacilityInventory spec types: ['ergo:gasFacilityInventory'] Error reading dataset: required dataset is missing - spec: {'id': 'gas_facilities', 'required': True, 'description': 'Gas facility Inventory', 'type': ['ergo:gasFacilityInventory']}

Is there an easy way to do that on dev?

I can get into the mongodb and fix that tomorrow.

navarroc commented 1 month ago

I think you might have to update the data type in that published gas facility inventory? dataset type does not match - given type: ncsa:gasFacilityInventory spec types: ['ergo:gasFacilityInventory'] Error reading dataset: required dataset is missing - spec: {'id': 'gas_facilities', 'required': True, 'description': 'Gas facility Inventory', 'type': ['ergo:gasFacilityInventory']}

Is there an easy way to do that on dev?

I can get into the mongodb and fix that tomorrow.

Thank you, I don't think I have all that setup to connect to mongo so I'd appreciate that.

ywkim312 commented 1 month ago

Here is the ergo output for comparison with the test script:

What should I compare to this one? I ran the test script and got a json file and csv file. CSV file doesn't look like the output of ergo you posted. Am I doing something wrong?

navarroc commented 1 month ago

Here is the ergo output for comparison with the test script:

What should I compare to this one? I ran the test script and got a json file and csv file. CSV file doesn't look like the output of ergo you posted. Am I doing something wrong?

Correct, because Ergo used different column naming scheme than IN-CORE. The GUID should match and then ls-slight is the same as LS_0 and so forth, None is DS_0 and so forth to compare values.