INCATools / dead_simple_owl_design_patterns

A simple system for specifying OWL class design patterns for OBO-ish ontologies.
http://incatools.github.io/dead_simple_owl_design_patterns/
GNU General Public License v3.0
41 stars 5 forks source link

simple tester should flag missing annotation property binding #54

Open matentzn opened 4 years ago

matentzn commented 4 years ago
annotations:
  - annotationProperty: oio:hasExactSynonym
    text: "acquired %s"
    vars:
     - disease

I dont know why, but this all by itself is rejected by dosdp tools (so I assume the spec rejects this)

This is accepted:

annotationProperties:
  exact_synonym: oio:hasExactSynonym 

annotations:
  - annotationProperty: exact_synonym
    text: "acquired %s"
    vars:
     - disease

@dosumis can you confirm which is at fault, the spec or DOSDP tools?

dosumis commented 4 years ago

Properties, like classes, need to be declared before they are used.

There's a simpler built-in short cut for oio APs corresponding to OBO tags though. You can just use this tag directly:

https://github.com/INCATools/dead_simple_owl_design_patterns/blob/master/spec/DOSDP_schema_full.yaml#L369 This should work:

generated_synonyms:
   - 
      text: "acquired %s"
      vars: 
         - disease

(Corrected)

matentzn commented 4 years ago

Ok! Then we need to make sure that simple-tester warns about the first case! Right now, they are ignored

matentzn commented 4 years ago

Along the same lines, we need to be warned of this case:

classes:
    acquired: MONDO:0021141

vars:
    disease: owl:Thing

(a VAR referring to something that is not declared in classes.

dosumis commented 4 years ago

Note to self: Should be possible to use JPATH to fix both.