search

INCATools / kgcl

Datamodel for KGCL (Knowledge Graph Change Language)
https://w3id.org/kgcl/
MIT License
11 stars 4 forks source link

How to identify the target subset in subset membership change operations? #41

Closed gouttegd closed 6 months ago

gouttegd commented 1 year ago

For the AddNodeToSubset and RemoveNodeToSubset changes, the subset the node should be added to/removed from is supposed to be represented by the in_subset slot of a AddToSubset or RemoveFromSubset mixin. That slot expects a OntologySubset, defined in ontology_model.yaml.

But OntologySubset has seemingly no slots at all (either directly or inherited from OntologyElement), so how one is supposed to know which subset the change is about?

Shouldn’t OntologySubset have a id slot to identify the subset?

gouttegd commented 6 months ago

Closing as this has been fixed by #62 (by making OntologySubset a type of Node, therefore giving it an ID).