search

INCATools / ontology-access-kit

Ontology Access Kit: A python library and command line application for working with ontologies
https://incatools.github.io/ontology-access-kit/
Apache License 2.0
126 stars 29 forks source link

review cross-ontology-diff datamodel prior to implementing #61

Open cmungall opened 2 years ago

cmungall commented 2 years ago

Currently the cross-ontology-diff code uses an ad-hoc tuple as the output:

https://github.com/INCATools/ontology-access-kit/blob/52771fef55cce0749863c3ea45a55bd7110f785e/src/oaklib/omk/omk_mapping_utils.py#L14

current results look like this:

('IDENTICAL', 'EMAPA:16037', 'rdfs:subClassOf', 'EMAPA:36032', [])
('OTHER', 'EMAPA:16041', 'rdfs:subClassOf', 'EMAPA:16039', [])

which is not so useful for review. We want to see labels, plus mapped concepts

We would like to move to a documented datamodel that may have applications beyond this software library:

https://incatools.github.io/ontology-access-kit/datamodels/cross-ontology-diff/index.html

Review this prior to implementing

cmungall commented 2 years ago

note that this does relate to KGCL which handles any kind of difference but I think the composition of mapping plus diff is important enough to have a small ad-hoc datamodel

matentzn commented 2 years ago

I think we need to discuss this in person.

pkalita-lbl commented 2 years ago

I reviewed the proposed data model and don't have any feedback at the moment. But I'd be happy to sit in on a discussion about it.

cmungall commented 2 years ago

Discussing with @matentzn we should have reused mapping_cardinality_enum rather than left/right functional