search

INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
215 stars 54 forks source link

Check if time consuming jq pipeline is still necessary #696

Open matentzn opened 1 year ago

matentzn commented 1 year ago

In the last ODK release, we switched to ROBOT 1.9.0 which comes with the latest OBO Graphs, which should be entirely immutable with stable serialisation. jq should no longer be necessary, we should try to remove it.

matentzn commented 1 year ago

Test:

  1. Run convert on ontology (check cl, uberon, mondo, ro)
  2. commit to some git branch (some bogus repo)
  3. Run convert again (should be ZERO diff)

Example commands:

robot convert -I http://purl.obolibrary.org/obo/cl.owl -f json -o cl.json

robot convert -I http://purl.obolibrary.org/obo/uberon.owl -f json -o uberon.json

shawntanzk commented 1 year ago

all looks good, tried with .obo files too, and all good :)

matentzn commented 1 year ago

Thanks Shawn I will take over now

matentzn commented 1 year ago

I am still witnessing cases where the sorting does not work properly, like RO