search

INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
220 stars 54 forks source link

Update `constraints.txt` fixes #831 #833

Closed hrshdhgd closed 1 year ago

hrshdhgd commented 1 year ago

fixes #831

gouttegd commented 1 year ago

That’s not how it is supposed to work…

The constraints.txt should never be updated manually; it’s strictly the output of PIP’s dependency resolution algorithm.

If there’s a Python package for which you would like to enforce some specific constraints, that should be done in the requirements.txt.full file, e.g.:

semsql >= 0.3

the constraint will then be picked up by the update-constraint action next time it is run (it can be run manually if there’s an urgent need to to create an ODK image with the new semql version), which will then update the constraints.txt file, taking into account the specific constraint on the package.

gouttegd commented 1 year ago

(@matentzn You broke the build the last time you tried to update constraints.txt, don’t you remember? :P )

matentzn commented 1 year ago

It was not manually updated, Harshad ran the script; don't worry. I also immediately ran the workflow again afterwards!

gouttegd commented 1 year ago

My bad.

But in that case it’s strange that the previous execution of the action earlier today didn’t update semsql, but the manual invocation a few hours later did…

matentzn commented 1 year ago

Indeed. I think what happened is that an OAK release today dealt with a bad dependency; not sure though