INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
219 stars 54 forks source link

Default component goal should be restricted to owl #880

Closed matentzn closed 1 year ago

matentzn commented 1 year ago

As it turns out, having a general goal for files in the components directory was a mistake for various reasons (see https://github.com/monarch-initiative/mondo-ingest/pull/299; in a nutshell, you cant overwrite a wildcard goal in make with another more specific wildcard goal - only with a concrete goal without wildcards).

This PR should:

cc @joeflack4

joeflack4 commented 1 year ago

Thanks for your attention to this @matentzn ! Were you able to test it out? Assuming it fixes the issue, is this something I can fix with update_repo, or do I have to wait for the next ODK release or?

gouttegd commented 1 year ago

is this something I can fix with update_repo, or do I have to wait for the next ODK release

Both! You will need to run update_repo to get the fix, but first you need to wait until the fix has made it into a release. For now the fix is only in the master branch, running update_repo would have no effect.

The update_repo command does not get the latest stuff straight from the ODK repository. It only updates your own repository against the latest ODK image that is locally available in your Docker setup.

matentzn commented 1 year ago

The fix is in :dev now: https://hub.docker.com/r/obolibrary/odkfull/tags!

@gouttegd thank your for your explanations. In the Repo @joeflack4 and I work on (not a real ontology pipeline), we use dev image for everything because we constantly need the latest tools, makefile fixes etc.