INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
223 stars 54 forks source link

add an RDF validator to check for spaces in IRIs #892

Closed balhoff closed 10 months ago

balhoff commented 1 year ago

It seems like a validation check was added in #691, but it looks like it's still letting in issues like this: https://github.com/obo-behavior/behavior-ontology/pull/181

Or else maybe NBO is not running that check? I caught this with Jena (tdb2.tdbloader). Maybe we should add a conversion to Turtle then check with riot --validate?

balhoff commented 1 year ago

Also:

gouttegd commented 1 year ago

The RDF/XML validation check is disabled by default. Users must set ensure_valid_rdfxml = True in their ODK configuration to enable it.

We used to have a LightRDF-based validation that was fast enough to be enabled by default, but we had to disable it because of a very weird bug (#743) in either LightRDF itself or the underlying Rust parser.

gouttegd commented 1 year ago

It seems the #743 bug can be fixed by updating the Rio libraries used by LightRDF (https://github.com/ozekik/lightrdf/issues/14). If we can get a new LightRDF release with updated dependencies, we could re-enable the LightRDF-based RDF/XML check by default.