search

INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
223 stars 54 forks source link

Fix the entrypoint script when ODK_USER_ID is 0. #900

Closed gouttegd closed 1 year ago

gouttegd commented 1 year ago

When we run with ODK_USER_ID=0, meaning the process inside the container must run under the identify of the superuser, make sure the arguments to the entrypoint script are quoted before exec'ing.

closes #899

gouttegd commented 1 year ago

Note that the test suite is running for absolutely nothing: we do not test running under the identity of the superuser (and I don’t think we should), so the code path that is modified by this PR is not tested. Leaving it running anyway since passing the tests is now needed for merging…

gouttegd commented 1 year ago

Please, for the love of Ken Thompson, Dennis Ritchie, and everything sacred in the Unix world, do not take this PR as an encouragement to keep running complex processes as root.

Had the ticket been opened by anyone else than you, I’d have closed it with “running the test suite as root is unsupported, go back to your quarters and think hard about your habits, #wontfix”. Then I would have banned you from ever opening a ticket on this repo again. :D

(I’m almost serious.)

matentzn commented 1 year ago

:D I know.. I will make myself a user on my server called "noob"!

matentzn commented 1 year ago

It worked perfect by the way!