INCATools / ontology-development-kit

Bootstrap an OBO Library ontology
http://incatools.github.io/ontology-development-kit/
BSD 3-Clause "New" or "Revised" License
214 stars 54 forks source link

New server, new problems: seed-via-docker.sh fails during `make tests` #913

Closed matentzn closed 11 months ago

matentzn commented 11 months ago

I am building a new server, trying to run make tests:

make test-flavor FLAVOR=full
make[1]: Entering directory '/home/matentzn/ws/ontology-development-kit'
make[2]: Entering directory '/home/matentzn/ws/ontology-development-kit'
Checking for ROBOT... OK
Checking for DOSDP-TOOLS... OK
Checking for OWLTOOLS... OK
Checking for AMMONITE... OK
Checking for ODK... OK
Checking for KONCLUDE... OK
Checking for SOUFFLE... OK
Checking for JENA... OK
Checking for SPARQL... OK
make[2]: Leaving directory '/home/matentzn/ws/ontology-development-kit'
make[2]: Entering directory '/home/matentzn/ws/ontology-development-kit'
./seed-via-docker.sh -c -C tests/test-module-mireot.yaml
This script only works with ODK 1.3.2 and later. For ODK 1.3.1 or earlier, use https://raw.githubusercontent.com/INCATools/ontology-development-kit/v1.3.1/seed-via-docker.sh
make[2]: *** [Makefile:55: tests/test-module-mireot.yaml] Error 1
make[2]: Leaving directory '/home/matentzn/ws/ontology-development-kit'
make[1]: *** [Makefile:110: test-flavor] Error 2
make[1]: Leaving directory '/home/matentzn/ws/ontology-development-kit'
make: *** [Makefile:118: test-full] Error 2
[19:59] [nc-ph-3053.semanticly.ai ontology-development-kit] $ id -u
1000

I am trying now to do everything by the book @gouttegd :D no more root user shenanigans etc.

Unfortuntately I don't get much of an error message here..

matentzn commented 11 months ago

Different than https://github.com/INCATools/ontology-development-kit/issues/899, but perhaps related.

gouttegd commented 11 months ago

Unfortuntately I don't get much of an error message here..

Well, we have this:

./seed-via-docker.sh -c -C tests/test-module-mireot.yaml
This script only works with ODK 1.3.2 and later. For ODK 1.3.1 or earlier, use https://raw.githubusercontent.com/INCATools/ontology-development-kit/v1.3.1/seed-via-docker.sh
make[2]: *** [Makefile:55: tests/test-module-mireot.yaml] Error 1

“Error 1” simply means that the command Make was trying to execute exited with a non-zero return code. The command it was trying to execute is the ./seed-via-docker.sh ... just above.

That script in its entirety is:

set -e

echo "This script only works with ODK 1.3.2 and later. For ODK 1.3.1 or earlier, use https://raw.githubusercontent.com/INCATools/ontology-development-kit/v1.3.1/seed-via-docker.sh"

ODK_IMAGE=${ODK_IMAGE:-odkfull}
ODK_TAG=${ODK_TAG:-latest}
ODK_GITNAME=${ODK_GITNAME:-$(git config --get user.name)}
ODK_GITEMAIL=${ODK_GITEMAIL:-$(git config --get user.email)}

docker run -e ODK_USER_ID=$(id -u) -e ODK_GROUP_ID=$(id -g) -v $PWD:/work -w /work --rm obolibrary/$ODK_IMAGE:$ODK_TAG /tools/odk.py seed --gitname "$ODK_GITNAME" --gitemail "$ODK_GITEMAIL" "$@"

The script managed to execute its first instruction (echo ...), since we can see the corresponding message in the output above.

The next two lines can’t possibly cause an error:

ODK_IMAGE=${ODK_IMAGE:-odkfull}
ODK_TAG=${ODK_TAG:-latest}

since they are nothing more than variable assignments, without any command to execute.

So what has failed is any one of the following three commands:

Given that it’s a new machine: have you set up your Git username and email on your account? git config --get user.name does return a non-zero error code if user.name has never been set.

matentzn commented 11 months ago

Thank you @gouttegd! I am really thankful for the time you keep pouring into helping me learn to swim :)