INCATools / ubergraph

Integrated OBO ontology store
BSD 3-Clause "New" or "Revised" License
43 stars 3 forks source link

cardiac muscle cell (sensu Arthopoda) unsatisfiability #123

Closed balhoff closed 1 year ago

balhoff commented 1 year ago

The Ubergraph unsatisfiability check reported a new problem. @gouttegd @bvarner-ebi does this look like anything that recently changed in CL?

cardiac muscle cell (sensu Arthopoda) SubClassOf Nothing

Axiom Impact

Axioms used 1 times

Ontologies used:

gouttegd commented 1 year ago

I (and others) have been adding some taxon restriction in several places, but I don’t recall adding one anywhere near the classes involved here…

I think the problematic bit is this one:

That tissue should be part of circulatory organ, which is taxon-neutral, instead of heart, which is vertebrate-specific. (Though this will require some careful checking: cardiac muscle tissue is a striated muscle tissue – are we sure that all heart-like organs are always made of striated muscle?)

In any case it does not look like this axiom was introduced recently, so I am concerned that the issue has never been flagged before. I did a complete merge of Uberon+CL+FBbt (plus the corresponding bridges) two days ago and didn’t catch anything.

balhoff commented 1 year ago

@gouttegd this check builds and integrates various ontologies from their source, with the aim of catching problems before release: https://github.com/INCATools/ubergraph/blob/master/ci/test-merged.sh — so it may be slightly different content from what you merged.

gouttegd commented 1 year ago

Thanks! That’s the kind of cross-ontology CI checks that I would like to see broadly adopted!

And right, I know why I didn’t catch anything: because I am stupid and I had not included the taxslim-disjoint-over-in-taxon.owl component in my own check, meaning that I was not set up to catch any taxon-related problem… 🤦

And now I have ~3,600 larval interneurons that are somehow unsatisfiable. :scream:

balhoff commented 1 year ago

@gouttegd thanks so much! The check is green again.