search

INCATools / ubergraph

Integrated OBO ontology store
BSD 3-Clause "New" or "Revised" License
43 stars 3 forks source link

Add GRLC endpoint for replaced_by annotations #79

Closed anitacaron closed 2 years ago

anitacaron commented 2 years ago

Fixes #77

matentzn commented 2 years ago

maybe get another review from @ubyndr

anitacaron commented 2 years ago

I tested here, and it also lists this case.

matentzn commented 2 years ago

I dont doubt the query returns all the information, but what I am saying is that an API user will be confused about the fact that some replacements are strings and others IRIs..

In Fact, its probably better to add an isIRI(?replacement_id) filter to the queries to avoid this, and make sure that we fix the ontologies..

anitacaron commented 2 years ago

I noticed that using alt_id gives the IRI and replaced_by gives in string.

matentzn commented 2 years ago

I noticed that using alt_id gives the IRI and replaced_by gives in string.

We should prioritise this not being the case for all our OWL releases.