search

INCF / BrainImagingPipelines

BIPs
Other
28 stars 31 forks source link

Variance normalization and detrending in CompCor #76

Open juhuntenburg opened 9 years ago

juhuntenburg commented 9 years ago

Hi, I just saw in the new CPAC release they updated the CompCor implementation to variance normalize the data, as in the original publication. https://github.com/FCP-INDI/C-PAC/commit/5a832836d92cdc5877db93aebeabd7c75a66713f

I am not sure, but from what I see there is no variance normalization (nor mean centering) in the BIPS implementation? Is that correct, and if so, is it an issue?

Also, is the detrending commented out because it is taken care of by the TSNR interface before?

satra commented 9 years ago

@juhuntenburg - for resting preprocessing please switch over to the example script in nipype itself. it's much more refined relative to the one in bips.

https://github.com/nipy/nipype/blob/master/examples/rsfmri_vol_surface_preprocessing_nipy.py#L261

juhuntenburg commented 9 years ago

@satra great, thanks a lot!