search

INCF / MUSIC

MUSIC, the MUltiSimulation Coordinator
GNU General Public License v3.0
37 stars 37 forks source link

Virtual destructor for EventHandlerGlobalIndex missing? #4

Closed uahic closed 8 years ago

uahic commented 8 years ago

Hi,

I just tried to compile Monsteer (which uses MUSIC) against the most recent MUSIC version but the compiler complains as follows:

error: ‘class SpikesHandler’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]

In src/music/event.hh it seems that a virtual destructor is missing (I just learned why its good to have one: http://stackoverflow.com/questions/5827719/class-has-virtual-functions-and-accessible-non-virtual-destructor)

Compiler: gcc 4.8.3

mdjurfeldt commented 8 years ago

This issue is now solved due to PR #7.