search

INCF / MUSIC

MUSIC, the MUltiSimulation Coordinator
GNU General Public License v3.0
37 stars 37 forks source link

Add function to load boolean values from config #49

Closed jakobj closed 6 years ago

jakobj commented 6 years ago

This PR adds a function that allows loading of boolean values from a config. Values need to be defined as true/false. See here https://github.com/incf-music/music-adapters/pull/5 for a use case.

jakobj commented 6 years ago

Sure I can fix it, but I am not sure what convention to follow exactly. To my naive eye the added code looks similar to the code surrounding it. Or do you mean in the whole file? Do you have conventions written down somewhere?

mdjurfeldt commented 6 years ago

Sure---it's these standards:

https://www.gnu.org/prep/standards/

Yes, unfortunately unformatted code has slipped in, but I am going to work towards a cleanup and am trying to enforce the coding style.

What I saw in your code was just a few missing spaces between function name and left paren.

Den 25 okt. 2017 14:11 skrev "Jakob Jordan" notifications@github.com:

Sure I can fix it, but I am not sure what convention to follow exactly. To my naive eye the added code looks similar to the code surrounding it. Or do you mean in the whole file? Do you have conventions written down somewhere?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/INCF/MUSIC/pull/49#issuecomment-339309274, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcfCUSUouVrXwsAoWFdoGkB25meqQJbks5svyVdgaJpZM4QFDj- .

jakobj commented 6 years ago

Thanks for the link. I've now added the few missing whitespaces.