search

INCF / MUSIC

MUSIC, the MUltiSimulation Coordinator
GNU General Public License v3.0
37 stars 37 forks source link

Send rudeconfig changes upstream #56

Closed sanjayankur31 closed 5 years ago

sanjayankur31 commented 5 years ago

There seem to be changes to the local copy of rudeconfig used in MUSIC which are not present in upstream (https://github.com/mflood/rudeconfig). These should be sent upstream---most downstream distributions do not permit private copies of libraries (bundling).

If these are improvements, I can diff the two sources (upstream and the local copy) and open PRs upstream?

sanjayankur31 commented 5 years ago

Hi there,

Any ideas/comments on this please?

mdjurfeldt commented 5 years ago

Hi Ankur,

The rudeconfig source code in MUSIC is customized for the MUSIC config file syntax. So, these changes cannot be sent upstream.

sanjayankur31 commented 5 years ago

Hi Ankur,

The rudeconfig source code in MUSIC is customized for the MUSIC config file syntax. So, these changes cannot be sent upstream.

I thought so. Do you think it's worth me speaking to rudeconfig upstream to see what they think? MUSIC seems like the only thing that uses rudeconfig at the moment.

At the moment, I'm using the bundled copy for the NeuroFedora MUSIC package. Should be reviewed and in Fedora soon.

mdjurfeldt commented 5 years ago

Well, if rudeconfig could be generalized in a way to support such extensions that would be nice, of course, but I'm not sure that that makes sense. Do as you find suitable.