Compiling NEST with MUSIC support, while using the -Woverloaded-virtual flag, generates a great deal of warnings, both from NEST code and from code included from MUSIC. These warnings are related to function declarations hiding virtual functions from the base class. I am in the process of fixing issue in the NEST code (see nest/nest-simulator#1377), but CI fails because of the amount of warnings generated when compiling NEST with MUSIC support.
This PR solves the issue indicated by the warnings in MUSIC code as well, by adding using directives to make the base class functions accessible. In connector.cc the NULL macro had to be replaced by nullptr to help the compiler select the right overloaded function.
terhorstd
commented
3 years ago
Compiling NEST with MUSIC support, while using the
-Woverloaded-virtualflag, generates a great deal of warnings, both from NEST code and from code included from MUSIC. These warnings are related to function declarations hiding virtual functions from the base class. I am in the process of fixing issue in the NEST code (see nest/nest-simulator#1377), but CI fails because of the amount of warnings generated when compiling NEST with MUSIC support.This PR solves the issue indicated by the warnings in MUSIC code as well, by adding
usingdirectives to make the base class functions accessible. Inconnector.cctheNULLmacro had to be replaced bynullptrto help the compiler select the right overloaded function.