search

INCF / csa

The Python implementation of the Connection-Set Algebra
GNU General Public License v3.0
13 stars 17 forks source link

Please split this package #11

Open dkfellows opened 5 years ago

dkfellows commented 5 years ago

Because this package supports plotting out of the box despite this not being the main purpose of the package, installing this package is really difficult to install in some environments (it's because matplotlib is tricky). Those environments include key use cases like some user configurations on MacOS X and on Continuous Integration services. Could you please split this package, perhaps into baseline csa and csa-plot (for the problem code, which is just in the csa/plot.py file), so that applications which don't need the plotting capability can install the rest of the code easily? Thanks!

apdavison commented 5 years ago

Rather than splitting, which would increase the maintenance burden for @mdjurfeldt, would it work to just make the plotting optional? i.e. if you installed without matplotlib, then you would get an error message when trying to use the plot functions.

mdjurfeldt commented 5 years ago

Splitting the package also introduces complexity.

An alternative solution could be to make the plotting optional---e.g. contingent on whether matplotlib is installed or not.

What is your view on that?

Den 20 sep. 2018 12:53 skrev "Donal Fellows" notifications@github.com:

Because this package supports plotting out of the box despite this not being the main purpose of the package, installing this package is really difficult to install in some environments (it's because matplotlib is tricky). Those environments include key use cases like some user configurations on MacOS X and on Continuous Integration services. Could you please split this package, perhaps into baseline csa and csa-plot (for the problem code, which is just in the csa/plot.py file), so that applications which don't need the plotting capability can install the rest of the code easily? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/INCF/csa/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcfCWHP43xYwQjnxpaLlnmPkAhoiQ3dks5uc3OwgaJpZM4Wx4Hx .

mdjurfeldt commented 5 years ago

@apdavison: We responded with the same idea simultaneously. 😊

rowleya commented 5 years ago

I think this would be fine for us (this was a request to make SpiNNaker software easier to install) - so long as matplotlib isn't listed as a requirement in setup.py or requirements.txt, it should work.

Jay-sanjay commented 1 year ago

hello , everyone I am a bit new to open-source contribution so would someone give me some issues to work on as a beginner