search

INCF / nineml-spec

Specification of the NineML model description language.
http://nineml.net
14 stars 9 forks source link

Piecewise functions #83

Closed tclose closed 9 years ago

tclose commented 9 years ago

This PR addresses issue #74.

In the MathML subset used by SBML you are able to define piecewise functions, which could (probably will) be the long term plan to support this feature. However, in the mean time this PR adds similar functionality to NineML MathInline syntax, copying most of the format from MathML.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.05%) to 75.17% when pulling 5b04ba07bb988c2ce1c849d027b8894bc1621024 on tclose:piecewise into 9e5b2323484e2af99356bff60fcb3bc14c2571f7 on INCF:master.

apdavison commented 9 years ago

Again, I don't think I can really review this until the refactoring PR is merged.

tclose commented 9 years ago

No worries, I am testing out the Brunel model now so hopefully I can get back to you soon.

On 3 February 2015 at 21:32, Andrew Davison notifications@github.com wrote:

Again, I don't think I can really review this until the refactoring PR is merged.

— Reply to this email directly or view it on GitHub https://github.com/INCF/nineml/pull/83#issuecomment-72642831.

Thomas G. Close, PhD. Postdoctoral Researcher, Computational Neuroscience Unit, Okinawa Institute of Science and Technology e: tclose@oist.jp w: +81 98 966 8804

tclose commented 9 years ago

I meant to say that I could rebase them on to the old master if there is a problem with the refactoring but if there is not a problem it would be easier to wait until it is merged

On 3 February 2015 at 21:34, Tom Close tclose@oist.jp wrote:

No worries, I am testing out the Brunel model now so hopefully I can get back to you soon.

On 3 February 2015 at 21:32, Andrew Davison notifications@github.com wrote:

Again, I don't think I can really review this until the refactoring PR is merged.

— Reply to this email directly or view it on GitHub https://github.com/INCF/nineml/pull/83#issuecomment-72642831.

Thomas G. Close, PhD. Postdoctoral Researcher, Computational Neuroscience Unit, Okinawa Institute of Science and Technology e: tclose@oist.jp w: +81 98 966 8804

Thomas G. Close, PhD. Postdoctoral Researcher, Computational Neuroscience Unit, Okinawa Institute of Science and Technology e: tclose@oist.jp w: +81 98 966 8804

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.08%) to 76.19% when pulling 48d92e75b1b19f6fb0cc23cdba296a9143075985 on tclose:piecewise into 86967a9560340ff3079143eedcf1e5252b269a58 on INCF:master.

tclose commented 9 years ago

Will reopen this in the new lib9ML repository