search

INET-Complexity / housing-model

Agent-based model of the UK housing market.
MIT License
39 stars 26 forks source link

Adding MASON jars #6

Closed davidrpugh closed 9 years ago

davidrpugh commented 9 years ago

@danftang

This is a placeholder PR for discussing how to add the relevant MASON jar files to the project so that we can break the dependency with the CRISIS library

davidrpugh commented 9 years ago

@danftang

Substantial progress. Now only have 5 compilation errors:

/Users/drpugh/Research/crisis-economics/housing/src/housing/HousingMarketTestGUI.java
Error:(153, 21) java: update() has protected access in sim.util.media.chart.ScatterPlotGenerator
Error:(158, 24) java: update() has protected access in sim.util.media.chart.ScatterPlotGenerator
Error:(163, 25) java: update() has protected access in sim.util.media.chart.ScatterPlotGenerator
Error:(211, 14) java: cannot find symbol
  symbol:   method setYAxisLabel(java.lang.String)
  location: variable chart of type sim.util.media.chart.ChartGenerator

I suspect that the above are quick fixes...

davidrpugh commented 9 years ago

@danftang

This is ready to merge. Model is now up and running on my machine without any reference to CRISIS code. I removed the jar files and instead downloaded the .jar files from Maven repository from within my IDE as this seems to be better practice. You will need to do the same in order for everything to work properly. To run the code I only needed to downloadmason-16.jar, jfreechart-1.0.17, and apache.commons.math3.

davidrpugh commented 9 years ago

@danftang

I added the calls to the update() method to update the scatter plots. If you added your changes to this branch, then we could merge both set of changes in one go.

davidrpugh commented 9 years ago

@danftang

I am going to go ahead and merge this PR into the master branch. Can I request that we use the master branch as our default branch? Earlier I said that it didn't matter which we used (and to me personally it doesn't) but there is an enforced convention within Git that there always be a branch called master (and I think that some Git functionality depends on the existence of such a branch).