search

INET-Complexity / isle

11 stars 20 forks source link

Refactor logger.py #106

Closed rht closed 5 years ago

rht commented 5 years ago

This changes obtain_log and restore_logger_object to force them to derive from the same list.

rht commented 5 years ago

I added a 4th commit that rewrites the log list to dict.

jsabuco commented 5 years ago

Thank you very much for the suggestion! I just have a few concerns.

Is this compatible with ensemble.py? I am not sure whether we can return dicts from the cloud. I tested it a few months ago and it was not possible only lists. It might have changed though.

Also if we store some stuff as a dict we also have to adapt all the plotters and visualization.py since the methods there are expecting a list not a dict.

rht commented 5 years ago

I can remove the last commit to make it a list-only refactor (then will open another PR once the cause of the issue is found).

rht commented 5 years ago

Removed the last commit.

jsabuco commented 5 years ago

Thank you very much for the pull request!!!