Dear Crimson: Below is the score breakdown for your proposal. Details of things that should be updated/revised are provided in separate issues. As you address them, you should close the individual issues.
You can do this in one of two ways:
On GitHub, by clicking on Close issue
Via a commit that directly addresses the issue.
Please use the second method wherever a fix can be tied to a commit. If you preface your commit messages with "Fixes", "Fixed", "Fix", "Closed", or "Close", the issue will be closed when you push the changes to your repo. For example, suppose you want to close issue #2 which, hypothetically, suggested that you add a new line to the README, your commit message can say something like Add a new line to the README, closes #2.
Once you've closed all of the other issues, close this one as well, so that going into the presentation you have no open issues remaining.
Available
Earned
Data
3
3
Proposal
5
4
Workflow
1
1
Teamwork
1
1
Total
10
9
Overall:
Very nice work! I really only missed seeing a timeline or something to tell me when different stages of the project would be completed.
Some minor issues:
There's redundancy in your code, remove either line 2 devtools::install_github("choonghyunryu/dlookr"), or line 10 dlookr, from the installed packages code.
Dear Crimson: Below is the score breakdown for your proposal. Details of things that should be updated/revised are provided in separate issues. As you address them, you should close the individual issues.
You can do this in one of two ways:
Please use the second method wherever a fix can be tied to a commit. If you preface your commit messages with "Fixes", "Fixed", "Fix", "Closed", or "Close", the issue will be closed when you push the changes to your repo. For example, suppose you want to close issue
#2
which, hypothetically, suggested that you add a new line to the README, your commit message can say something likeAdd a new line to the README, closes #2
.Once you've closed all of the other issues, close this one as well, so that going into the presentation you have no open issues remaining.
Overall: Very nice work! I really only missed seeing a timeline or something to tell me when different stages of the project would be completed.
Some minor issues:
devtools::install_github("choonghyunryu/dlookr")
, or line 10dlookr,
from the installed packages code.