search

INFO-526-S24 / project-01-Crimson

https://info-526-s24.github.io/project-01-Crimson/
0 stars 1 forks source link

Write-up feedback #8

Closed Gchism94 closed 5 months ago

Gchism94 commented 5 months ago

Dear Crimson: Below is the score breakdown for your write-up. Details of things that should be updated/revised are provided in separate issues. As you address them, you should close the individual issues.

You can do this in one of two ways:

Please use the second method wherever a fix can be tied to a commit. If you preface your commit messages with "Fixes", "Fixed", "Fix", "Closed", or "Close", the issue will be closed when you push the changes to your repo. For example, suppose you want to close issue #2 which, hypothetically, suggested that you add a new line to the README, your commit message can say something like Add a new line to the README, closes #2.

Once you've closed all of the other issues, close this one as well, so that going into the presentation you have no open issues remaining.

Write-up

Available Earned
Introduction 2 2
Justification of approach 6 (3/Question) 6
Code 6 (3/Question) 6
Visualization 8 (4/Question) 7
Discussion 8 (4/Question) 8
Total 30 29

Feedback: Overall, very good work!

Similar plot issues as in the presentation, but here also I have a couple other suggestions:

  1. The COVID-19 and Lower Ad Revenue annotations should have had a white background to make them stand out better.
  2. The avg return of 5 years %s could have been to the tenths place, and the negative values should be differently colored than the positive.
ArunKoundinya commented 5 months ago

Fixes will be closed in next git commit for both the pointers.