Code peer review - Githubissues

INFO526-DataViz / project-final-Data-Dynamos

Data Dynamos team GitHub repository for Final Project from INFO 526 @ UArizona

https://info526-dataviz.github.io/project-final-Data-Dynamos/

0 stars 0 forks source link

Code peer review #6

Closed thanooshakarri closed 11 months ago

thanooshakarri commented 11 months ago

The following is the peer review of the project proposal by Infographic Innovators. The team members that participated in this review are

Eshaan Mathakari: @eshaanmathakari

Bharath Velamala: @bharath03-a

Thanoosha Naidu Karri: @thanooshakarri

Antonio Escalante Jr: @datalyticsintel

1. Purpose of Code

[X] Clearly defined and understood
[ ] Ambiguous or unclear

2. Code Quality

[X] Code is clean, readable, and well-organized
[X] Adequate comments explaining complex or tricky code sections
[X] Variables, methods, and classes have meaningful names
[X] Consistent code style (indentation, naming conventions, etc.)

3. Documentation

[X] Code documentation (e.g., comments) is sufficient
[ ] Readme or other documentation updated if necessary

4. Best Practices

[X] No hardcoded values; constants used appropriately
[ ] Security and privacy concerns addressed (e.g., no sensitive data exposed)
[ ] Code avoids repetition and promotes reusability

5. Additional Comments

The ggplot package is loaded for every r chunk in the file(code repetition).

6. Recommendation

[ ] Approved - ready to be merged
[X] Approved with minor issues - can be addressed later
[ ] Requires changes - provide feedback and request another review

Swati09Das commented 11 months ago

Hello Team,

We have addressed the issue of code repetition (#155cf015b51e60f9f1e7ac00bfe694fc0c0be756).

Thanks & Regards, Data Dynamos