search

INL / corpus-frontend

BlackLab Frontend, a feature-rich corpus search interface for BlackLab.
16 stars 7 forks source link

<Pagination>false</Pagination> in search.xml does not remove pagination from article view #522

Closed fadhleryani closed 3 months ago

fadhleryani commented 3 months ago

This setting works as expected in the official release, but not when I build from the current repo

KCMertens commented 3 months ago

Is the article actually truncated? Or are you talking about the widget being visible when it shouldn't be?

fadhleryani commented 3 months ago

I'm referring to the widget. My documents are small enough to not need pagination, and the widget covers the text when pagination is enable which requires dragging the widget away to make the text behind it visible.

KCMertens commented 3 months ago

I can't seem to reproduce this. I've made a small enhancement where the page and hit sections are now hidden independently if there would only be 1 page. If both would be hidden the entire widget is now hidden.

I do wonder what could be going on though. Can you check some things for me?

And finally, what are the values of these variables on the page (check in browser console)? They should be something like this:

fadhleryani commented 3 months ago

Thanks! I pulled your latest change and it seemed to fix the issue. Now pagination is always off, and hits counter is only there when there are multiple hits. This is regardless of whether the pagination option is set to true or not.

* You're in the `dev` branch

I was, and now I'm in the new dev after your update.

* Are you sure the corpus's Search.xml is read? Try changing `SearchInterface.InterfaceProperties.DisplayName` and see if it's reflected on the page. You'll always need to restart the server after making changes to Search.xml (unless you've set `cache=false` in the `corpus-frontend.properties`.

I think there is something off here, because changing the DisplayName only works in the article page. In the search page, when I hard refresh I see the DisplayName for a second before it goes back to the name specified in the blf file.

And finally, what are the values of these variables on the page (check in browser console)? They should be something like this:

* PAGE_SIZE -> 2.147.483.647

yes

  • PAGE_START -> 0 yes
  • PAGE_END -> equals to DOCUMENT_LENGTH No! this equals page size 2147483647
  • DOCUMENT_LENGTH -> anything over 0 is fair game 156
KCMertens commented 3 months ago

No! this equals page size 2147483647

Ah, this seems to be a bug. Though it doesn't change behaviour. Will fix regardless.

I think there is something off here, because changing the DisplayName only works in the article page. In the search page, when I hard refresh I see the DisplayName for a second before it goes back to the name specified in the blf file.

Another bug! Will fix.

KCMertens commented 3 months ago

This should now be fixed. Feel free to reopen if it still misbehaves