INM-6 / swan

Swan (Sequential Waveform Analyzer) is an open-source graphical tool for tracking single units across multiple sessions of electrophysiological data that was recorded using chronically implanted microelectrode arrays.
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Multiple control flow issues in ParameterInputDialog of Swan Implementation #47

Open shashwatsridhar opened 2 years ago

shashwatsridhar commented 2 years ago

In the current implementation, the ParameterInputDialog for the Swan Implementation has three buttons - Cancel, Update Plot and Calculate. For one run of the algorithm, the Update Plot button must be clicked first in order to instantiate different Kmeans Solvers, and only then should the Calculate button be clicked. This is not clear from the design of the GUI itself, it's worth:

Additionally, this line should be fixed so that the chosen_solver is not looked for unless _solvers is an empty list. It should essentially read:

if not self._solvers:

This should also fix the error which is raised when Cancel is pressed in the ParameterInputDialog.