search

INN / doubleclick-for-wp

WordPress plugin for serving Google Ad Manager ads
https://wordpress.org/plugins/doubleclick-for-wp/
GNU General Public License v2.0
25 stars 11 forks source link

Widget should include css for the `.display-none` class used when an ad does not load #16

Closed benlk closed 7 years ago

benlk commented 8 years ago

In https://github.com/INN/DoubleClick-for-WordPress/blob/master/js/vendor/jquery.dfp.js/jquery.dfp.js#L319, if an ad loads successfully, then the display-none class is removed from the ad.

    $adUnit.removeClass('display-none').addClass('display-' + display);

We don't provide any CSS for that class, and so ads are not getting hidden when they are not loaded.

This issue is probably a good time to tackle #9 as well.

For RNS-167