INN / doubleclick-for-wp

WordPress plugin for serving Google Ad Manager ads
https://wordpress.org/plugins/doubleclick-for-wp/
GNU General Public License v2.0
25 stars 11 forks source link

63: filter data, rearrange plugin includes #81

Closed benlk closed 5 years ago

benlk commented 5 years ago

This PR is a WIP. 🚨

Changes

Housekeeping:

Implementation of https://github.com/INN/doubleclick-for-wp/issues/63#issuecomment-393342611 to allow filtering of options used by jquery.dfp.js:

Why

For https://github.com/INN/doubleclick-for-wp/issues/63 and GDPR compliance

Testing/Questions

Questions that need to be answered before merging:

Steps to test this PR:

  1. ...
benlk commented 5 years ago

This is probably not going to make it into 0.3 because of time constraints, but there's room for it in a follow-up release.

benlk commented 5 years ago

refactoring in progress, but the network code is not being output! dfpId is not being set to the value of the network_code option in window.dfp_options. In js/jquery.dfw.js, Object.assign should be returning the contents of dfw with the specified items overwriting the values in window.dfw.

benlk commented 5 years ago

Bumping to 0.4, sorry.

benlk commented 5 years ago

Testing complete locally; lazy-loaded and non- alike render.

Testing complete on a staging site using DFW to serve ads: