improve backwards-compatibility support after VIP compatibility changes - Githubissues

INN / doubleclick-for-wp

WordPress plugin for serving Google Ad Manager ads

https://wordpress.org/plugins/doubleclick-for-wp/

GNU General Public License v2.0

25 stars 11 forks source link

improve backwards-compatibility support after VIP compatibility changes #88

Closed benlk closed 5 years ago

benlk commented 5 years ago

Changes

Adds some conditionals for fallback for previous variable names that were change in https://github.com/INN/doubleclick-for-wp/pull/46
Corrects some docs that were incorrect as a result of #46.

Why

Because https://github.com/INN/doubleclick-for-wp/pull/46 changed some global variables, properties, methods, array keys, and similar things.

For https://github.com/INN/doubleclick-for-wp/pull/46

Testing/Questions

Questions that need to be answered before merging:

[x] Does it update the changelog in readme.txt with appropriate information? — mostly handled in the branch 83-tag-0.3
[x] Does a plugin settings, version 0.2.1, display in 0.3? Is it saved correctly?
[x] Does a widget, version 0.2.1, display in 0.3? Is it saved correctly?

Steps to test this PR:

set up the plugin at v0.2 on a fresh install of WordPress, and configure it
Upgrade the plugin to this branch.
Answer the questions above.

benlk commented 5 years ago

This is a PR into branch 83-tag-0.3 because this contains changes atop of that branch.

benlk commented 5 years ago

Yep, works.