INN / doubleclick-for-wp

WordPress plugin for serving Google Ad Manager ads
https://wordpress.org/plugins/doubleclick-for-wp/
GNU General Public License v2.0
25 stars 11 forks source link

No google ad manager ads appearing anywhere on website #90

Open wendywoo2018 opened 5 years ago

wendywoo2018 commented 5 years ago

Site was displaying all our google ads but following a plug-in update 6 days ago they have all disappeared. All the ad units are correct in the widgets.

benlk commented 5 years ago

Hi Wendy,

Can you send us a screenshot of your SCAMP settings page, screenshots of the widget settings, and your site's URL? If you're not comfortable posting them publicly here, you can send us an email at support@inn.org.

wendywoo2018 commented 5 years ago

http://www.ni4kids.com screenshot 2018-11-12 at 16 13 44 screenshot 2018-11-12 at 16 13 09 screenshot 2018-11-12 at 16 12 59

wendywoo2018 commented 5 years ago

I haven't updated our other site scotland4kids.com to newest version 0.3 - its still on 0.2 and ads appearing fine

wendywoo2018 commented 5 years ago

Hi Ben those are posted – any help would be great as our impressions have dropped to zero and we have inventory to deliver – panic stations!

[signature_1808356678]http://www.familymediagroup.co.uk/

Wendy McCague Art Director T: 028 9002 0129

FAMILY MEDIA GROUP

Unit 5a, 21 Old Channel Road, Belfast BT3 9DE | T: 028 9002 0129

[signature_670061931]http://www.ni4kids.com/ Magazine of the Year – CIPR 2013

[signature_1256990443]http://www.scotland4kids.com/ New Scottish Magazine of the Year – PPA 2016

Print | Digital | Social | Events

[signature_947034617]http://www.facebook.com/ni4kids[signature_2120394608]https://twitter.com/ni4kids [signature_492202484] https://www.instagram.com/ni4kids/ [signature_1704964400] https://www.pinterest.co.uk/ni4kids [signature_1715263065] https://www.youtube.com/user/ni4kids

From: Ben Keith notifications@github.com Reply-To: INN/doubleclick-for-wp reply@reply.github.com Date: Monday, 12 November 2018 at 16:10 To: INN/doubleclick-for-wp doubleclick-for-wp@noreply.github.com Cc: Wendy McCague Wendy.McCague@ni4kids.com, Author author@noreply.github.com Subject: Re: [INN/doubleclick-for-wp] No google ad manager ads appearing anywhere on website (#90)

Hi Wendy,

Can you send us a screenshot of your SCAMP settings page, screenshots of the widget settings, and your site's URL? If you're not comfortable posting them publicly here, you can send us an email at support@inn.orgmailto:support@inn.org.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/INN/doubleclick-for-wp/issues/90#issuecomment-437937444, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AiE-PR6Bz7J_qZHv2vX91e4E4jEumRmoks5uuZ1agaJpZM4YZyFT.

benlk commented 5 years ago

That information is all useful to us; thank you.

If you go to https://ni4kids.com/?google_force_console=1, the Google Publisher Console should appear on your site. In it, there'll be an item for each ad on the page:

screen shot 2018-11-12 at 12 29 51 pm

At the very bottom of each item, there's a "Delivery Diagnostics" link. Can you click that for the ni4kids_970x250 ad unit, and tell us what it says? There's additional details about this process at https://support.google.com/admanager/answer/7066157 and https://support.google.com/admanager/answer/7449957, but what we're looking for is any information from Google about the "Ad unit failed to fetch" message provided in the google console.

While we work on fixing this problem, you can download the previous version of this plugin, 0.2.1, from the drop-down at the bottom of https://wordpress.org/plugins/doubleclick-for-wp/advanced/


The following notes in this ticket are for our records, so we can continue debugging if you decide to revert to the earlier version of the plugin.

For the ni4kids_970x250 ad slot you provided the screenshot for, the corresponding entry in the mappings array on window.dfw is mappings1, which has the following contents:

        "mapping1": [{
            "browser": [0, 1],
            "ad_sizes": [
                [320, 50]
            ]
        }, {
            "browser": [480, 1],
            "ad_sizes": [
                [728, 90]
            ]
        }, {
            "browser": [768, 1],
            "ad_sizes": [
                [970, 250],
                [970, 90],
                [728, 90]
            ]
        }],

That matches the screenshot.

For the ni4Kids_HalfPage ad unit, it's mapping2:

        "mapping2": [{
            "browser": [0, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }, {
            "browser": [480, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }, {
            "browser": [768, 1],
            "ad_sizes": [
                [300, 600]
            ]
        }],

That also matches the screenshot.

The full `window.dfw` ```js var dfw = { "dfpID": "12503408", "network_code": "12503408", "mappings": { "mapping1": [{ "browser": [0, 1], "ad_sizes": [ [320, 50] ] }, { "browser": [480, 1], "ad_sizes": [ [728, 90] ] }, { "browser": [768, 1], "ad_sizes": [ [970, 250], [970, 90], [728, 90] ] }], "mapping2": [{ "browser": [0, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 600] ] }], "mapping3": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping4": [{ "browser": [0, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 600] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 600] ] }], "mapping5": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping6": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping7": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping8": [{ "browser": [0, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [480, 1], "ad_sizes": [ [300, 250] ] }, { "browser": [768, 1], "ad_sizes": [ [300, 250] ] }], "mapping9": [{ "browser": [0, 1], "ad_sizes": [ [320, 50] ] }, { "browser": [480, 1], "ad_sizes": [ [728, 90] ] }, { "browser": [768, 1], "ad_sizes": [ [728, 90] ] }] }, "targeting": { "Page": ["front-page"] } }; ```
wendywoo2018 commented 5 years ago

I reinstalled 0.2.1 but it won’t let me activate and not appearing in settings

benlk commented 5 years ago

That's disturbing. If you copy the plugin from the functional site to the broken site, does that work?

benlk commented 5 years ago

(she said yes, in a helpscout email.)

But someone else has reported this, not using the widget but using the $doubleclick->place_ad() function inheriting from global $doubleclick, which used global $DoubleClick before 0.3.

Here's the difference in the page output, using a testing site:

499,502c499
<   <div
<               class='dfw-unit'
<                   data-adunit='ET_SideBox'
<                   data-size-mapping='mapping1'></div></aside>
---
>   <div class='dfw-unit' data-adunit='ET_SideBox' data-size-mapping='mapping1'></div></aside>
640c637
< <link rel='stylesheet' id='dfp-css'  href='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/css/dfp.css?ver=0.2.0' type='text/css' media='all' />
---
> <link rel='stylesheet' id='dfp-css'  href='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/css/dfp.css?ver=0.3.0' type='text/css' media='all' />
653c650
< <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/vendor/jquery.dfp.js/jquery.dfp.min.js?ver=0.2.0'></script>
---
> <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/vendor/jquery.dfp.js/jquery.dfp.min.js?ver=0.3.0'></script>
656c653
< var dfw = {"networkCode":null,"mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
---
> var dfw = {"dfpID":"1234567","network_code":"1234567","mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
659c656
< <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/jquery.dfw.js?ver=0.2.0'></script>
---
> <script type='text/javascript' src='http://mwcir.test/wp-content/plugins/doubleclick-for-wp/js/jquery.dfw.js?ver=0.3.0'></script>
661,665c658
<               jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp({
<                   dfpID: '1234567',
<                   collapseEmptyDivs: false,
<                   setTargeting: {"Page":["home","front-page"]},
<                   sizeMapping: {"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]}                });
---
>               jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp( window.dfw );

Removing the differences that are pure version number:

499,502c499
<   <div
<               class='dfw-unit'
<                   data-adunit='ET_SideBox'
<                   data-size-mapping='mapping1'></div></aside>
---
>   <div class='dfw-unit' data-adunit='ET_SideBox' data-size-mapping='mapping1'></div></aside>
656c653
< var dfw = {"networkCode":null,"mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
---
> var dfw = {"dfpID":"1234567","network_code":"1234567","mappings":{"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]},"targeting":{"Page":["home","front-page"]}};
661,665c658
<               jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp({
<                   dfpID: '1234567',
<                   collapseEmptyDivs: false,
<                   setTargeting: {"Page":["home","front-page"]},
<                   sizeMapping: {"mapping1":[{"browser":[1,1],"ad_sizes":[]},{"browser":[66,1],"ad_sizes":[]},{"browser":[1066,1],"ad_sizes":[[300,600]]}]}                });
---
>               jQuery('.dfw-unit:not(.dfw-lazy-load)').dfp( window.dfw );

And there's not a significant difference there, so what's going on?