INN / doubleclick-for-wp

WordPress plugin for serving Google Ad Manager ads
https://wordpress.org/plugins/doubleclick-for-wp/
GNU General Public License v2.0
25 stars 11 forks source link

Fix for non-lazy-load ads not displaying correctly #97

Open benlk opened 5 years ago

benlk commented 5 years ago

Changes

Why

For #95 and #96.

Resolves https://github.com/INN/doubleclick-for-wp/issues/94

Testing/Questions

Questions that need to be answered before merging:

Steps to test this PR:

  1. Create a non-lazy-load ad widget in the page, with size mappings.
  2. With version 0.3, verify that the plugin doesn't request a correct ad size
  3. With this PR, verify that the plugin does request a correct ad size .
benlk commented 5 years ago

This PR may also address the following issues:

benlk commented 5 years ago

Test release of this plugin created: https://github.com/INN/doubleclick-for-wp/archive/v0.3.1-rc1.zip

Submitted to that one wp.org user for testing: https://wordpress.org/support/topic/do-not-use-version-0-3/#post-11181996