Closed benlk closed 4 years ago
@benlk A couple of questions:
Updated the code to cover the cases where:
No-image still looks like a big white empty spot:
This screenshot shows off the error message text, as well as the improved descriptions for the various inputs.
Are media credit attributes supposed to show? I can't get any to appear.
@joshdarby Are you setting them when uploading the image?
Are you setting them when uploading the image?
@benlk No, I was setting them while choosing an image to use. I'll try uploading a new image and setting them there.
Edit: This worked.
No, I was setting them while choosing an image to use.
That's bothersome; I wonder if it's a bug in Largo?
Now includes a fix for https://github.com/INN/inn/blob/92015727927463627355e88e88774a44e7ac76b9/functions.php#L268-L284:
Warning: array_key_exists(): The first argument should be either a string or an integer in /umbrella-inndev/wp-content/themes/inn/functions.php on line 279
Upon deploy, set this up with the settings from https://github.com/INN/inn/issues/124
Changes
Why
for #125
Questions
See questions in #125. Also:
Note that, post-deploy, there will be no configured homepage.
Testing
After checking out this branch, check the homepage with:
Image:
Headline:
Blurb:
Button:
Link: