INN / inn

WordPress child theme for INN.org. Requires Largo parent theme (https://github.com/INN/largo)
https://inn.org
GNU General Public License v2.0
2 stars 2 forks source link

Customizer-controlled homepage #127

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

Screen Shot 2020-04-17 at 20 05 11 Screen Shot 2020-04-17 at 20 13 34

Why

for #125

Questions

See questions in #125. Also:

Note that, post-deploy, there will be no configured homepage.

Testing

After checking out this branch, check the homepage with:

Image:

Headline:

Blurb:

Button:

Link:

joshdarby commented 4 years ago

@benlk A couple of questions:

benlk commented 4 years ago

Updated the code to cover the cases where:

No-image still looks like a big white empty spot:

Screen Shot 2020-04-20 at 16 03 39

This screenshot shows off the error message text, as well as the improved descriptions for the various inputs.

benlk commented 4 years ago

Are media credit attributes supposed to show? I can't get any to appear.

@joshdarby Are you setting them when uploading the image?

Screen Shot 2020-04-20 at 15 26 32

joshdarby commented 4 years ago

Are you setting them when uploading the image?

@benlk No, I was setting them while choosing an image to use. I'll try uploading a new image and setting them there.

Edit: This worked.

benlk commented 4 years ago

No, I was setting them while choosing an image to use.

That's bothersome; I wonder if it's a bug in Largo?

benlk commented 4 years ago

Now includes a fix for https://github.com/INN/inn/blob/92015727927463627355e88e88774a44e7ac76b9/functions.php#L268-L284:

Warning: array_key_exists(): The first argument should be either a string or an integer in /umbrella-inndev/wp-content/themes/inn/functions.php on line 279

benlk commented 4 years ago

Upon deploy, set this up with the settings from https://github.com/INN/inn/issues/124