Closed benlk closed 4 years ago
Is this deployed to staging?
I don't see it on http://inndev.staging.wpengine.com/
How can styles be improved here?
I'll leave that one to @MirandaEcho
Are we concerned about what this form looks like if the subscribe form does not load? Does this need fallback content inside the div?
It might be a good idea to have some sort of error message there if the form doesn't load.
Feedback:
There is no specific setting for the header link to the Subscribe button; it is in a Custom HTML widget.
Therefore, this PR now implements Customizer fields for changing the headline, blurb, button text, and button link for the newsletter subscribe area of the homepage.
Approved for prod.
Changes
This pull request makes the following changes:
Why
For https://github.com/INN/umbrella-inndev/issues/165#issuecomment-655135189 and https://secure.helpscout.net/conversation/1213856192/5823?folderId=2730118
Testing/Questions
Features that this PR affects:
-
Questions that need to be answered before merging:
div
?Steps to test this PR: