INN / inn

WordPress child theme for INN.org. Requires Largo parent theme (https://github.com/INN/largo)
https://inn.org
GNU General Public License v2.0
2 stars 2 forks source link

replace embedded MailChimp form with Customizer controls for headline, blurb, and button #131

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

This pull request makes the following changes:

Screen Shot 2020-07-07 at 23 55 27

Why

For https://github.com/INN/umbrella-inndev/issues/165#issuecomment-655135189 and https://secure.helpscout.net/conversation/1213856192/5823?folderId=2730118

Testing/Questions

Features that this PR affects:

-

Questions that need to be answered before merging:

Steps to test this PR:

  1. Visit the homepage of the INN site and scroll down to "Stay Up To Date"
joshdarby commented 4 years ago

Is this deployed to staging?

I don't see it on http://inndev.staging.wpengine.com/

How can styles be improved here?

I'll leave that one to @MirandaEcho

Are we concerned about what this form looks like if the subscribe form does not load? Does this need fallback content inside the div?

It might be a good idea to have some sort of error message there if the form doesn't load.

benlk commented 4 years ago

Feedback:

benlk commented 4 years ago

Screen Shot 2020-07-13 at 19 00 35

There is no specific setting for the header link to the Subscribe button; it is in a Custom HTML widget.

Therefore, this PR now implements Customizer fields for changing the headline, blurb, button text, and button link for the newsletter subscribe area of the homepage.

benlk commented 4 years ago

Approved for prod.