1678 banner redux - Githubissues

INN / inn

WordPress child theme for INN.org. Requires Largo parent theme (https://github.com/INN/largo)

https://inn.org

GNU General Public License v2.0

2 stars 2 forks source link

1678 banner redux #55

Closed benlk closed 6 years ago

benlk commented 6 years ago

Changes

removes the newsmatch logo
changes the paragraph text color in the alert from #fff to the body copy color #555
changes the enqueued stylesheet from style.css to css/style.css, and removes the redirect from style.css. style.css is no longer loaded by browsers; this saves us an HTTP query before styles are loaded.
updates the cachebuster string

screen shot 2018-01-23 at 7 44 02 pm

screen shot 2018-01-23 at 7 44 11 pm

screen shot 2018-01-23 at 7 44 21 pm

Questions

Is the font weight okay at bold or should it be normal?
555?
How do we feel about keeping the green just for that link?

Why

HelpScout ticket 1678: https://secure.helpscout.net/conversation/506860125/1678/?folderId=1219602

For right now would remove logo and add a banner/bar. Thank you News Match donors for supporting nonprofit newsrooms! Make News Match in that sentence still link to NewsMatch.org. We'll be updating that for year-around use.

kaylima commented 6 years ago

@benlk looks good to me! I'll let @julia67 weigh in on font weight, color, and link treatment.

julia-smith commented 6 years ago

Looks good to me.