Fix layout-breaking left margin on hero elements in single posts - Githubissues

INN / inn

WordPress child theme for INN.org. Requires Largo parent theme (https://github.com/INN/largo)

https://inn.org

GNU General Public License v2.0

2 stars 2 forks source link

Fix layout-breaking left margin on hero elements in single posts #81

Closed benlk closed 6 years ago

benlk commented 6 years ago

Changes

reimplement 6f8f3cef9a28eca5477f15160f7ec36c9737eefa for https://github.com/INN/largo/issues/1401 in the inn.org theme, but this time in style.less instead of common.less, meaning that this change is scoped just to the inn.org theme.
removes left margin on hero element in single posts
changes how the css stylesheet is enqueued so that we no longer have to bump the cachebuster string
removes the cachebuster string from the pull request template

Before:

screen shot 2018-08-24 at 1 38 53 pm

screen shot 2018-08-24 at 1 39 01 pm

After:

screen shot 2018-08-24 at 2 02 27 pm

Why

With the margin, the element was positioned such that the page was wider than the viewport.

Questions

[ ] what other single-page templates do we need to check for this besides the jobs template?
[ ] why was https://github.com/INN/inn/commit/6f8f3cef9a28eca5477f15160f7ec36c9737eefa removed originally?

benlk commented 6 years ago

Yes, that would be preferable, but it's a change we'd want to make in Largo as that's where this problem comes from. https://github.com/INN/largo/issues/1401