search

INN / inn

WordPress child theme for INN.org. Requires Largo parent theme (https://github.com/INN/largo)
https://inn.org
GNU General Public License v2.0
2 stars 2 forks source link

adding services to list of custom left sidebar menu pages #96

Closed kaylima closed 5 years ago

kaylima commented 5 years ago

Changes

Added the Services as a page that will have a left sidebar menu of child pages. Cleaned up logic for showing menu.

Why

The Services section of inn.org is new and comprised of many different related pages. It needs its' own menu, similar to the current About page.

Questions

@benlk How does the switch/case look? And, how should we test?

kaylima commented 5 years ago

@benlk see https://github.com/INN/inn/pull/96/commits/d163c032a5dc73629ba6f4dae1af05efabe8abf5 and https://github.com/INN/inn/pull/96/commits/ea51da4f674facbd6ee10b4ecda981714c50fe3b for updates

benlk commented 5 years ago

Updated with various code quality fixes and bug fixes in this file.

This is based off of the current "master" branch, which is not what's currently deployed to inn.org. The deployed branch appears to be https://github.com/INN/inn/tree/tyler-style-refresh from https://github.com/INN/inn/pull/93, at commit https://github.com/INN/inn/pull/93/commits/c7c69cdd503a57ce6c5262b3d3a89979e9c4dbbf from 28 days ago.

This code is deployable, but before deploying this branch, we need to discuss:

benlk commented 5 years ago

Have now merged #93 into master, and master into this branch.

benlk commented 5 years ago

Oh, this is merging into staging

benlk commented 5 years ago

Have now merged master into staging: a fast-forward merge that brought staging up to match master. This PR now only reflects the differences made in this PR, and not the differences from #93 or previous work on master since staging was last merged into master.