INN / link-roundups

A WordPress plugin to make it easy to collect links from around the web, turn them into roundup posts and streamline the production of daily/weekly roundup newsletters using MailChimp. Built and maintained by INN Labs.
https://wordpress.org/plugins/link-roundups/
GNU General Public License v2.0
20 stars 4 forks source link

In 4.6, new styles make for interesting update pages #122

Closed benlk closed 8 years ago

benlk commented 8 years ago
screen shot 2016-08-22 at 2 26 28 am
# http://vagrant.dev/wp-admin/load-styles.php?c=0&dir=ltr&load%5B%5D=dashicons,admin-bar,common,forms,admin-menu,dashboard,list-tables,edit,revisions,media,themes,about,nav-menus,widgets,site-icon,&load%5B%5D=l10n,buttons,wp-auth-check,wp-color-picker&ver=4.6
.button.installing:before, .button.updating-message:before, .import-php .updating-message:before, .update-message p:before, .updating-message p:before {
    color: #f56e28;
    content: "\f463";
}
# http://vagrant.dev/wp-admin/load-styles.php?c=0&dir=ltr&load%5B%5D=dashicons,admin-bar,common,forms,admin-menu,dashboard,list-tables,edit,revisions,media,themes,about,nav-menus,widgets,site-icon,&load%5B%5D=l10n,buttons,wp-auth-check,wp-color-picker&ver=4.6
.button.installed:before, .button.installing:before, .button.updated-message:before, .button.updating-message:before, .import-php .updating-message:before, .update-message p:before, .updated-message p:before, .updating-message p:before {
    display: inline-block;
    font: 400 20px/1 dashicons;
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
    vertical-align: top;
}

It's just a class conflict; we can change the markup in the plugin from .update-message to something else.

Cosmetic issue, but should this be taken care of before we mark it ready for WordPress 4.6?

aschweigert commented 8 years ago

Seems like a quick fix, sure go ahead.

benlk commented 8 years ago

Done in https://github.com/INN/link-roundups/commit/df9fcdc30e5902d4e39514398936ce3f9f84359f

benlk commented 8 years ago

And finished in https://github.com/INN/link-roundups/commit/77f1f1a912c0d22c8c27c0ea4409bba540aec718