INN / link-roundups

A WordPress plugin to make it easy to collect links from around the web, turn them into roundup posts and streamline the production of daily/weekly roundup newsletters using MailChimp. Built and maintained by INN Labs.
https://wordpress.org/plugins/link-roundups/
GNU General Public License v2.0
20 stars 4 forks source link

PHP >= 7 compatibility? #132

Closed benlk closed 5 years ago

benlk commented 6 years ago

From the PHP version check plugin:

FILE: /Users/blk/sites/ipbs/wp-content/plugins/link-roundups/inc/saved-links/class-saved-links-widget.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

9 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.

FILE: /Users/blk/sites/ipbs/wp-content/plugins/link-roundups/inc/link-roundups/class-link-roundups-editor.php

FOUND 1 ERROR AND 40 WARNINGS AFFECTING 41 LINES

143 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (content) { %><%= con... 146 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% _.each(actions, function... 147 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= k %> button button-prim... 148 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% }); %> 153 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= name %> 154 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= name %>" block.

160 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (hasPosts) { %>loadin... 161 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (hasPosts) { %>Loadin... 179 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% posts.each(function(post... 180 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post.get('ID') %>"> 181 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post.get('post_title') ... 182 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post.getStatus() %></em... 185 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post.get('ID') %>" href... 188 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post.get('ID') %>" href... 192 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% }); %> 197 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post_title %> 200 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post_title %>"/> 204 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (custom_fields.lr_sub... 205 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= custom_fields.lr_subhed... 206 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else { %> 207 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= custom_fields.lr_subhed... 208 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } %> 212 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (custom_fields.lr_url... 213 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= custom_fields.lr_url %>... 214 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else if (post_permalin... 215 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post_permalink %>" /> 216 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else { %> 218 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } %> 222 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (custom_fields.lr_des... 223 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= custom_fields.lr_desc %... 224 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else if (post_excerpt)... 225 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= post_excerpt %></textar... 226 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else { %> 228 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } %> 232 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (custom_fields.lr_sou... 233 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= custom_fields.lr_source... 234 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else if (source) { %> 235 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= source %>" /> 236 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else { %> 238 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } %> 335 | ERROR | Function split() is deprecated since PHP 5.3 and removed since PHP 7.0; Use preg_split() instead

The biggest one is:

335 | ERROR | Function split() is deprecated since PHP 5.3 and removed since PHP 7.0; Use preg_split() instead

benlk commented 5 years ago

./inc/link-roundups/class-link-roundups-editor.php: $foundIds = split(',', $group);

benlk commented 5 years ago

PHP message: PHP Notice: Undefined index: hook_suffix in /Users/blk/sites/energynews/wp-admin/includes/class-wp-screen.php on line 213 PHP message: PHP Notice: Trying to get property 'id' of non-object in /Users/blk/sites/energynews/wp-content/plugins/link-roundups/inc/saved-links/class-saved-links-list-table.php on line 182