search

INN / maine-legislature

Application to make public the sources of income for Maine legislators
http://apps.pinetreewatch.org/maine-legislature/
MIT License
0 stars 0 forks source link

New field: businesses owned by self or family #82

Closed benlk closed 7 years ago

benlk commented 7 years ago

We'd like to add a new field, equal in weight and styling to "Non-governmental positions" and listed immediately before that field (see attached screenshot). The new field should be: Businesses owned by self or family. The data for this new category should be pulled from the income_business tab (in the current version, that data is being exported into the Sources of income/personal income field).

for ben-screen shot 2017-10-30 at 11 36 18 am

benlk commented 7 years ago

First, it looks like you made the new category "Personal businesses" and listed it as a subcategory under "Sources of Income." Instead, we really need it to be titled "Businesses owned by self or family" and presented as a top-level category, one that has identical weight and styling as the "Sources of Income" label. Can you do this?

  • [x] change style Second, we would like you create another new field, equal in weight and styling to "Non-governmental positions" and listed immediately before that field, but immediately after the "Businesses owned by self or family" that we are requesting above. The new field should be titled: "Other political positions." The data for this new category should be pulled from the position_political tab. However, the new category should contain only the data for every row in which the value of Column B equals the value of Column D. Additionally, for the data that meet this requirement, the values in Column D should be omitted from appearing in the app. We do not want the name of the legislator to be listed in this new category, only the name of the committee and title of the position in the committee.
  • [x] new helper for getting "other political positions"
  • draws from position_political
  • if sh_name === Name_of_Official add the thing
  • based off of the businesses template, but just show the political position thing. If the values of Column B and Column D are not the same, the data should remain how it is in the current version, i.e. getting exported into the Sources of income/family member sources of income field. The values in Column D should NOT be omitted in this case, as we want to clarify which family member holds the position being listed.
  • [x] modify the family member positions thing to only add it if sh_name != Name_of_Official
benlk commented 7 years ago

Closing 'cos it's done.