Closed joshdarby closed 4 years ago
How do we want to handle the narrowest screens?
@benlk I think it's fine like that. Even at 200px width it still doesn't look horrible. Plus, if someone is using a screen at 200px I think they'll see more issues than just the subscribe button
There are probably still folks using 320px iPhones, though.
Right, but it still looks ok at that size.
@benlk can this be merged or do you have more concerns with it?
If you're okay with it, then sure. I don't like how the sticky nav doubles in height, but we don't have a good fix for that.
Changes
This pull request makes the following changes:
Subscribe
button to the header and sticky navDesktop:
Sticky:
Mobile:
Why
For #7
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR: