Closed joshdarby closed 4 years ago
https://github.com/INN/umbrella-aspenj/pull/14/commits/914bbfc846d5f65e51bf79309d2704445664473f / https://github.com/INN/umbrella-aspenj/pull/14/commits/d4583ca81e92b7ffcb6a2b553c1c85c20572ff83 changes the cutoff time from 12PM to 12:30PM.
After speaking with Brent this afternoon he mentioned he wants the email to send at 12PM, so this extra 30 minutes will (hopefully) give Mailchimp enough time to process the email before the posts from the current day (today before 12:30PM and after yesterday at 12:30PM) disappear
Three questions:
The RSS feed puts the most-recent items first. Is that the right order for his purposes?
He never mentioned a specific order they should be in. I'm not sure it matters in this context.
Do we want to make the cutoff time configurable by Brent?
He never explicitly stated the need for that; he just mentioned he wants it to be 12PM.
Would we want to add this to Link Roundups, eventually?
That would be a nice addition! If we do eventually add it, maybe we can add in configurable cutoff times.
Changes
This pull request makes the following changes:
?feed=daily-roundup
, based on the Largo Mailchimp feed, with a few modifications:<link>
is the saved link<source>
is the saved link sourceWhy
For #6
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
time()
to grab the time it's usingcurrent_time()
instead so it grabs the WP timezone time, which is set to Mountain. Do we need any other timezone considerations here that I missed?Steps to test this PR: