INN / umbrella-caribbean

Umbrella repo for Caribbean Investigative News
GNU General Public License v2.0
0 stars 2 forks source link

Create a third custom sidebar for Spanish posts #95

Open MirandaEcho opened 4 years ago

benlk commented 4 years ago

This should be doable by creating the sidebar in Largo's options, or by using https://wpml.org/documentation/getting-started-guide/translating-widgets/

benlk commented 4 years ago

Alternative: put all the single-post widgets in the same sidebar, but control which ones show up by the language selector https://wpml.org/documentation/getting-started-guide/translating-widgets/displaying-different-widgets-for-different-languages/

This would require 0 additional dev hours.

benlk commented 4 years ago

Question: Is the language selector sufficient for this purpose?

MirandaEcho commented 4 years ago

I'll need more information to answer that question. Does the language selector create a Spanish version of the sidebar on posts?

benlk commented 4 years ago

It does not create a separate Spanish-specific sidebar. Rather, it allows certain widgets to be shown only in particular languages, so that the the post sidebar will contain English and Spanish widgets, but only English or Spanish widgets will be displayed on a post.

This also applies to https://github.com/INN/umbrella-caribbean/issues/94

MirandaEcho commented 4 years ago

Requirement: When a user of the site clicks over to the Spanish version of the homepage, and then clicks into a Spanish version of an article, the sidebar content will be in Spanish without having to click on another "English/Spanish" toggle.

@benlk If this meets that requirement, then this works!

benlk commented 4 years ago

I believe this meets that requirement. We can provide them the docs at https://wpml.org/documentation/getting-started-guide/translating-widgets/displaying-different-widgets-for-different-languages/ for them to test to make sure.

benlk commented 4 years ago

Following on #94, all other widget areas have been translated, and I've duplicated the newsletter signup Gravity Form to translate that as well.

benlk commented 4 years ago

This is ready for them to review.